Merge master to master-vs-deps #51352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ErrorOutput` field is not used in the compiler protocol because the compiler never writes to stderr. This was complicating the code path for no good reason and hence I decided to remove it.
Refactor a bit and clean up some comments to help make the flow of data a bit clearer here.
This change adds structured messages to the binlog about the behavior of the compiler server. These messages will help users, our own developers and automation understand the behavior of the compiler server within a build.
Co-authored-by: Sam Harwell <[email protected]>
Merge release/dev16.10 to master
Avoid capture allocation in AnalyzerFileReference.GetSupportedLanguages
Co-authored-by: Rikki Gibson <[email protected]>
Handle failed SaveAsync operations
Provide structured information in binlog for the compiler server
…expressions (#51213) Co-authored-by: CyrusNajmabadi <[email protected]> Co-authored-by: Bernd Baumanns <[email protected]>
…218.7 (#51334) [master] Update dependencies from dotnet/arcade
…er-to-master-vs-deps
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into master-vs-deps.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout merges/master-to-master-vs-deps git reset --hard upstream/master-vs-deps git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-master-vs-deps --force